Add pre-commit config for pyflakes
#28
Conversation
| @@ -0,0 +1,6 @@ | |||
| repos: | |||
| - repo: https://github.com/pycqa/flake8 | |||
| rev: '4.0.1' | |||
There was a problem hiding this comment.
I'd prefer to keep this unpinned. Whenever pyflakes is updated it may create new failures, but those are also things we'd want to know about. Also we are going to want to add 3.10 testing pretty soon, and I don't know if this versions supports it yet.
There was a problem hiding this comment.
Ah, I had just used the latest release tag (didn't think to unpin it, makes sense). The 4.0 release was tested for py3.10 it looks like at least.
There was a problem hiding this comment.
Is there any way to remove this? I tried removing it but that causes it to fail.
|
This is fine. It seems optional. We can try generate stubs too. Sometimes, I do manually update the stubs from a PR to the API repo so that I don't have to wait for it to get merged. Also the API repo is going to change to rst pretty soon, which will break generate stubs until it gets updated. |
I keep on forgetting to run
pyflakesbefore pushing, so I thought I'd usepre-commit. Here's a minimal config for the tool. As there doesn't seem to be apre-commithook forpyflakesitself, I just useflake8and run only the pyflake-related checks viaflake8 --select F. I've also updated the linting workflow to usepre-commit, to keep consistency (although I doubtflake8versions will change the pyflake linting behaviour).It is "another thing", so I understand if you're not interested in merging. For the future I was thinking it might be nice to create a custom
pre-commithook that ensured any staged changes to./generate_stubs.pywould trigger a check to see the related files have been updated.